Dropping Python 2.7 #122
Merged
Dropping Python 2.7 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
reviewed
Nov 16, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [3.7, 3.8, 3.9, 2.7] | |||
| python-version: [3.7, 3.8, 3.9] | |||
There was a problem hiding this comment.
Don't you test py 3.10 & 3.11 (and 3.12 is coming)?
There was a problem hiding this comment.
I mean to have this PR contain minimal changes needed for dropping Python 2.7, so that your review will not be distracted.
There is already another pending PR that is to add py 3.10, 3.11, 3.12 testing.
xiangyan99
reviewed
Nov 16, 2023
xiangyan99
reviewed
Nov 16, 2023
rayluo
force-pushed
the
drop-py27
branch
2 times, most recently
from
a556bff
to
c682207
Compare
xiangyan99
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test automation were failing due to the infrastructure already dropped Python 2.7 support.