Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2.7 #122

Merged
merged 1 commit into from
Nov 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, 3.8, 3.9, 2.7]
python-version: [3.7, 3.8, 3.9]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you test py 3.10 & 3.11 (and 3.12 is coming)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean to have this PR contain minimal changes needed for dropping Python 2.7, so that your review will not be distracted.

There is already another pending PR that is to add py 3.10, 3.11, 3.12 testing.

os: [ubuntu-latest, windows-latest, macos-latest]
include:
# https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-environment-variables-in-a-matrix
Expand All @@ -27,8 +27,6 @@ jobs:
toxenv: "py38"
- python-version: 3.9
toxenv: "py39"
- python-version: 2.7
toxenv: "py27"
- python-version: 3.9
os: ubuntu-latest
lint: "true"
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ persistence.save(json.dumps(data))
assert json.loads(persistence.load()) == data
```

## Python version support policy

Python versions which are 6 months older than their
[end-of-life cycle defined by Python Software Foundation (PSF)](https://devguide.python.org/versions/#versions)
will not receive new feature updates from this library.


## Community Help and Support

Expand Down
7 changes: 6 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
# https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

[bdist_wheel]
universal=1
universal=0

[metadata]
license = MIT
project_urls = Changelog = https://github.com/AzureAD/microsoft-authentication-extensions-for-python/releases
classifiers =
License :: OSI Approved :: MIT License
Development Status :: 5 - Production/Stable
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
description = Microsoft Authentication Library extensions (MSAL EX) provides a persistence API that can save your data on disk, encrypted on Windows, macOS and Linux. Concurrent data access will be coordinated by a file lock mechanism.
13 changes: 3 additions & 10 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,13 @@
long_description=long_description,
long_description_content_type="text/markdown",
package_data={'': ['LICENSE']},
python_requires=">=3.7",
install_requires=[
'msal>=0.4.1,<2.0.0',

# In order to implement these requirements:
# Lowerbound = (1.6 if playform_system == 'Windows' else 1.0)
# Upperbound < (3 if python_version >= '3.5' else 2)
# The following 4 lines use the `and` syntax defined here:
# https://www.python.org/dev/peps/pep-0508/#grammar
"portalocker<3,>=1.0;python_version>='3.5' and platform_system!='Windows'",
"portalocker<2,>=1.0;python_version=='2.7' and platform_system!='Windows'",
"portalocker<3,>=1.6;python_version>='3.5' and platform_system=='Windows'",
"portalocker<2,>=1.6;python_version=='2.7' and platform_system=='Windows'",
"portalocker<3,>=1.0;platform_system!='Windows'",
"portalocker<3,>=1.6;platform_system=='Windows'",

"pathlib2;python_version<'3.0'",
## We choose to NOT define a hard dependency on this.
# "pygobject>=3,<4;platform_system=='Linux'",

Expand Down
Loading