Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RT to broker apps #1126

Merged
merged 16 commits into from
Sep 4, 2020
Merged

Expose RT to broker apps #1126

merged 16 commits into from
Sep 4, 2020

Conversation

rpdome
Copy link
Member

@rpdome rpdome commented Aug 10, 2020

Allowing Broker apps to extract BRT to perform WPJ.

related PR: AzureAD/microsoft-authentication-library-common-for-android#996

@shahzaibj
Copy link
Contributor

@rpdome Can you add more details? Perhaps a link to an ADO work item? I'm not clear on what we are trying to accomplish and why? (Broker apps aren't using MSAL right? how is this helping them?)

@rpdome
Copy link
Member Author

rpdome commented Aug 11, 2020

@rpdome Can you add more details? Perhaps a link to an ADO work item? I'm not clear on what we are trying to accomplish and why? (Broker apps aren't using MSAL right? how is this helping them?)

They will, for device code flow.
https://identitydivision.visualstudio.com/Engineering/_boards/board/t/Auth%20Client%20-%20Android/Backlog%20items/?workitem=1076089

Copy link
Contributor

@shoatman shoatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just not sure about the public API change. Other than that nits.

changelog Outdated Show resolved Hide resolved
@rpdome rpdome requested a review from shoatman August 19, 2020 22:51
@rpdome rpdome requested a review from iambmelt August 27, 2020 23:49
Copy link
Contributor

@shoatman shoatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Thanks Dome.

@rpdome rpdome merged commit e703849 into dev Sep 4, 2020
@rpdome rpdome deleted the rapong/exposeRtToBrokerApps branch September 4, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants