Give BrokerMsalController higher priority than LocalMsalController if available #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would happen in the following scenario
would the user be prompted? |
Silent requests will fallback to local controller so no prompt. |
fadidurah
approved these changes
Feb 22, 2024
somalaya
approved these changes
Feb 28, 2024
somalaya
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Mar 20, 2024
Issue : AT PoP generate SHR tests are failing in the daily pipeline Cause : In this PR, we changed the order of the controller - AzureAD/microsoft-authentication-library-for-android#2040. We are first adding BrokerMsalController if broker is installed. After this change, GenerateSHRCommand was first trying to generateSHR with BrokerMsalController and it would succeed. But the result is not returned. It would then try with LocalMsalController and fails because the account is added to broker. This is an existing bug which got surfaced with recent changes. Fix : Return from GenerateSHRCommand with the result if a controller returns a successful response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Giving BrokerMsalController higher priority than LocalMsalController if available. This means that if Broker is available, msal will first try to acquire token via broker before trying its localController
Why
In order to push brokered auth as default when available. And reduce usage of regular RT, when PRT can be used which is bound to the device.
How
Changing the order of controllers to put BrokerMsalController (if eligible) before LocalMsalController
Testing
Verified AcquireTokenSilent calls reach Broker first.