Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch MsalClientException when user cancels auth instead of serviceEx… #587

Merged
merged 5 commits into from Jul 5, 2018
Merged

catch MsalClientException when user cancels auth instead of serviceEx… #587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a8fdb1
catch MsalClientException when user cancels auth instead of serviceEx…
jennyf19 Jun 30, 2018
4114c9e
Add unit test coverage for user cancelling authentication and access …
jennyf19 Jul 2, 2018
028e4ec
address empty queue error and add assert.fail for when exception is n…
jennyf19 Jul 2, 2018
0dc7ef6
add return statement...working w/other branch and forgot to add it he…
jennyf19 Jul 2, 2018
5a7f8d1
fix spelling
jennyf19 Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Microsoft.Identity.Client/Internal/Requests/InteractiveRequest.cs
View file
Open in desktop
Expand Up @@ -258,6 +258,12 @@ private void VerifyAuthorizationResult()
MsalErrorMessage.NoPromptFailedErrorMessage);
}

if (_authorizationResult.Status == AuthorizationStatus.UserCancel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at adding tests for this class? A unit tests should have failed when you added these lines, but it clearly did not since the PR passed. I think it is important to lock this down with unit tests because the exceptions we throw are part of the public API, i.e. if we throw a different exception from one release to the other we have broken customers' handling code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

{
throw new MsalClientException(_authorizationResult.Error,
_authorizationResult.ErrorDescription);
}

if (_authorizationResult.Status != AuthorizationStatus.Success)
{
throw new MsalServiceException(_authorizationResult.Error,
Expand Down