Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #782

Merged
merged 2 commits into from
Jan 14, 2019
Merged

initial commit #782

merged 2 commits into from
Jan 14, 2019

Conversation

jennyf19
Copy link
Collaborator

No description provided.

Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
A few suggestions, but this is a really good start

changelog.txt Outdated
@@ -1,3 +1,12 @@
2.7.0
=============
- **Debugging into MSAL was not possible**. MSAL now supports source link. This means developers can debug into MSAL, using VS 15.7+, which will allow them to generate a snukpg package that contains the pdb files (one per platform) and they can add a manifest containing urls to source files in the nuget package. Use the NuGet package explorer to see this manifest. [MSAL PR](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/pull/750)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fantastic, @jennyf19.

I would just replace "Debugging into MSAL was not possible" by "You can now step into MSAL.NET's source code from your application consuming it with NuGet" or something like that

I would replace MSAL did not support Xamarin.Mac by MSAL.NET not supports Xamarin.Mac

And Migration from ADALv2 to MSALv2 was not possible due to exposure of the refresh token in ADALv2 by Easier migration from ADALv2 to MSALv2 due to a new AcquireTokenFromRefreshToken API

the others are perfect.

The reason why I propose to turn these 3 as positive sentences is they are new features. For the bugs it's ok to keep what you had.

Thanks very much!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feedback...have updated the file.

changelog.txt Outdated
@@ -1,3 +1,12 @@
2.7.0
=============
- **Debugging into MSAL was not possible**. MSAL now supports source link. This means developers can debug into MSAL, using VS 15.7+, which will allow them to generate a snukpg package that contains the pdb files (one per platform) and they can add a manifest containing urls to source files in the nuget package. Use the NuGet package explorer to see this manifest. [MSAL PR](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/pull/750)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSAL integrates SourceLink https://github.com/dotnet/sourcelink. This allows MSAL to embed pdb files and source code in the NuGet package, allowing users to debug into MSAL without replacing their package reference with a project reference.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @bgavrilMS

@jennyf19 jennyf19 merged commit 4262e8c into master Jan 14, 2019
@jennyf19 jennyf19 deleted the jennyf/changelog2.7 branch January 17, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants