Remove class attribute from script tag #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
sameerag,
jmckennon and
DarylThayil
|
LGTM, but is there a reason coveralls says are code coverage went down so much? Does it just have a bit of variance? |
jmckennon
approved these changes
Nov 13, 2019
It looks like there is some variance, I'll take a look at that later. Not sure why there would be variance, but when I re-ran the build it said no change. |
jasonnutter
approved these changes
Nov 13, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix. Class attr on script tag doesn't add anything as far as I know, and there was an issue raised a while back (#117).