Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Code Flow for Single Page Applications: Adding Redirect Handling Code #1164

Conversation

pkanher617
Copy link
Contributor

This PR adds interaction to the Authorization Code Flow version of the MSAL library.

The current implementation of MSAL determines the type of interaction at processing time instead of when the specific API is called. This PR introduces an IInteractionHandler abstract class which specifies which functions need to be handled when performing different methods of interaction. There will be a separate PR which extends this class for popup scenarios.

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments otherwise looks good!

Copy link
Contributor

@DarylThayil DarylThayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small questions / nitpicks but has my approval

Copy link
Contributor

@jmckennon jmckennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkanher617 pkanher617 merged commit b5477b7 into authorization-code-flow-logger Jan 6, 2020
@pkanher617 pkanher617 deleted the authorization-code-flow-redirect-handler branch January 23, 2020 21:49
azure-pipelines bot pushed a commit to pkanher617/microsoft-authentication-library-for-js that referenced this pull request Jan 4, 2022
…redirect-handler

Authorization Code Flow for Single Page Applications: Adding Redirect Handling Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants