Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Code Flow for Single Page Applications: Response Handling Code #1183

Conversation

pkanher617
Copy link
Contributor

This PR adds the response handling to the authorization code flow for single page applications.

This PR does NOT cover token caching or cache cleanup, those will be addressed in the next immediate PR. Please review PRs #1164 and #1181 before reviewing this PR.

Copy link
Contributor

@DarylThayil DarylThayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, otherwise looks good.

lib/msal-common/src/error/ClientAuthError.ts Outdated Show resolved Hide resolved
lib/msal-common/src/response/ResponseHandler.ts Outdated Show resolved Hide resolved
@pkanher617 pkanher617 changed the base branch from authorization-code-flow-acquireTokenImpl to authorization-code-flow-base January 8, 2020 03:48
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments, can be addressed in later PRs.

@pkanher617 pkanher617 merged commit c4eaad0 into authorization-code-flow-base Jan 14, 2020
@pkanher617 pkanher617 deleted the authorization-code-flow-handleTokenResponse branch January 23, 2020 21:49
azure-pipelines bot pushed a commit to pkanher617/microsoft-authentication-library-for-js that referenced this pull request Jan 4, 2022
…handleTokenResponse

Authorization Code Flow for Single Page Applications: Response Handling Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants