Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api sso silent #1166

Merged
merged 17 commits into from Apr 20, 2020
Merged

Api sso silent #1166

merged 17 commits into from Apr 20, 2020

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Dec 17, 2019 •
edited by jasonnutter

Introduce an API: ssoSilent() as a wrapper for calling acquireTokenSilent() with clientId to acquire an id_token.

Fixes #900

@coveralls
Copy link

coveralls commented Dec 17, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 77.982% when pulling ae18384 on api-ssoSilent into 52d43d7 on dev.

@sameerag sameerag marked this pull request as ready for review December 17, 2019 19:56
jasonnutter
jasonnutter suggested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see tests and documentation (e.g. adding an example to the README). And maybe a sample?

lib/msal-core/src/UserAgentApplication.ts Outdated Show resolved Hide resolved
@sameerag sameerag mentioned this pull request Dec 18, 2019
Closed
@jasonnutter jasonnutter mentioned this pull request Dec 18, 2019
Closed
4 tasks
@sameerag sameerag self-assigned this Dec 19, 2019
@DarylThayil
Copy link
Contributor

overall good, let me know when you have looked at comments and want another review.

@sameerag sameerag mentioned this pull request Jan 15, 2020
Closed
@jasonnutter jasonnutter mentioned this pull request Feb 26, 2020
Closed
@jasonnutter jasonnutter mentioned this pull request Mar 17, 2020
Closed
5 tasks
@winperec winperec mentioned this pull request Apr 1, 2020
Closed
5 tasks
@jasonnutter jasonnutter added this to the msal@1.3.0 - Release milestone Apr 16, 2020
This was referenced Apr 16, 2020
Closed
Closed
@jasonnutter jasonnutter mentioned this pull request Apr 17, 2020
Merged
@sameerag
Copy link
Member Author

LGTM. I cannot approve as I created the PR but looks like you have two reviews already. Please check the minor comments before merging though.

@jasonnutter
Copy link
Contributor

LGTM. I cannot approve as I created the PR but looks like you have two reviews already. Please check the minor comments before merging though.

Done.

@jasonnutter jasonnutter merged commit 7f036ce into dev Apr 20, 2020
@sameerag sameerag deleted the api-ssoSilent branch May 4, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@DarylThayil DarylThayil DarylThayil left review comments

@pkanher617 pkanher617 pkanher617 approved these changes

Assignees

@sameerag sameerag

Labels
None yet
Projects
None yet
Milestone
msal@1.3.0 - Release
Development

Successfully merging this pull request may close these issues.

Support Login Silent If Feasible
5 participants
@sameerag @coveralls @DarylThayil @jasonnutter @pkanher617