Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Silent Iframe Flow in Authorization Code Flow #1451

Merged
merged 40 commits into from Apr 23, 2020
Merged

Adding Silent Iframe Flow in Authorization Code Flow #1451

merged 40 commits into from Apr 23, 2020

Conversation

pkanher617
Copy link
Contributor

This PR adds iframe handling code as well as a new API to acquire authorization codes silently in an iframe when session cookies are available on the service.

@pkanher617 pkanher617 self-assigned this Apr 2, 2020
@pkanher617
Copy link
Contributor Author

Still need to add unit tests

@coveralls
Copy link

coveralls commented Apr 8, 2020 •
edited

Coverage Status

Coverage decreased (-0.1%) to 79.645% when pulling f181187 on iframe-handler-2.0 into d085c9d on dev.

@tnorling tnorling mentioned this pull request Apr 22, 2020
Merged
@DarylThayil
Copy link
Contributor

This looks really well tested thanks!@

DarylThayil
DarylThayil approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@DarylThayil DarylThayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasonnutter
jasonnutter approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise looks good!

sameerag
sameerag approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Good job in separating the flows @pkanher617 :)

@pkanher617 pkanher617 merged commit 30f995b into dev Apr 23, 2020
@pkanher617 pkanher617 mentioned this pull request May 13, 2020
Closed
15 tasks
@pkanher617 pkanher617 deleted the iframe-handler-2.0 branch June 8, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@DarylThayil DarylThayil DarylThayil approved these changes

@sameerag sameerag sameerag approved these changes

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@jmckennon jmckennon Awaiting requested review from jmckennon

Assignees

@pkanher617 pkanher617

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pkanher617 @coveralls @DarylThayil @jasonnutter @tnorling @sameerag