Authorization Code Flow for Single Page Applications: Token Caching and Cleanup #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
DarylThayil,
jmckennon and
sameerag
sameerag
reviewed
Jan 13, 2020
jasonnutter
reviewed
Jan 13, 2020
jasonnutter
suggested changes
Jan 13, 2020
sameerag
reviewed
Jan 13, 2020
sameerag
reviewed
Jan 13, 2020
jmckennon
reviewed
Jan 13, 2020
|
Good work! Over all simplifying tokenProcessing the same way you did for loginRequest() helps in readability IMO. |
…rization-code-flow-cachingAndCleaning
pkanher617
changed the base branch from
authorization-code-flow-handleTokenResponse
to
authorization-code-flow-base
sameerag
approved these changes
Jan 15, 2020
jasonnutter
approved these changes
Jan 15, 2020
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…cachingAndCleaning Authorization Code Flow for Single Page Applications: Token Caching and Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add token caching and cache cleanup after requests to the authorization code flow for single page applications.
Please review PRs #1181 and #1183 before this PR.