New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization Code Flow for Single Page Applications: Popup Handler and AcquireToken Implementation #1190
Merged
pkanher617
merged 9 commits into
authorization-code-flow-base
from
authorization-code-flow-popupHandler
Jan 16, 2020
Merged
Authorization Code Flow for Single Page Applications: Popup Handler and AcquireToken Implementation #1190
pkanher617
merged 9 commits into
authorization-code-flow-base
from
authorization-code-flow-popupHandler
Jan 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
DarylThayil,
jmckennon and
sameerag
January 8, 2020 03:47
jasonnutter
suggested changes
Jan 9, 2020
jmckennon
reviewed
Jan 13, 2020
sameerag
reviewed
Jan 13, 2020
sameerag
reviewed
Jan 14, 2020
…ization-code-flow-popupHandler
…ization-code-flow-popupHandler
jmckennon
approved these changes
Jan 15, 2020
sameerag
reviewed
Jan 15, 2020
pkanher617
changed the base branch from
authorization-code-flow-cachingAndCleaning
to
authorization-code-flow-base
January 15, 2020 22:10
sameerag
reviewed
Jan 16, 2020
sameerag
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one comment.
jasonnutter
reviewed
Jan 16, 2020
jasonnutter
reviewed
Jan 16, 2020
jasonnutter
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor things, otherwise LGTM
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…popupHandler Authorization Code Flow for Single Page Applications: Popup Handler and AcquireToken Implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds popup handling and acquire token implementations to the authorization code flow for single page applications.
Please review PR #1183 before this PR.