Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Code Flow for Single Page Applications: Popup Handler and AcquireToken Implementation #1190

Merged

Conversation

pkanher617
Copy link
Contributor

This PR adds popup handling and acquire token implementations to the authorization code flow for single page applications.

Please review PR #1183 before this PR.

@pkanher617 pkanher617 changed the base branch from authorization-code-flow-cachingAndCleaning to authorization-code-flow-base January 15, 2020 22:10
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one comment.

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things, otherwise LGTM

@pkanher617 pkanher617 merged commit fcc4ab9 into authorization-code-flow-base Jan 16, 2020
@pkanher617 pkanher617 deleted the authorization-code-flow-popupHandler branch January 23, 2020 21:49
azure-pipelines bot pushed a commit to pkanher617/microsoft-authentication-library-for-js that referenced this pull request Jan 4, 2022
…popupHandler

Authorization Code Flow for Single Page Applications: Popup Handler and AcquireToken Implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants