[msal-node][msal-common] client applications, authorization code and device code implementation #1434
+28,232
−2,573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[msal-node] lerna bootstrap and lerna builds
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
pkanher617
reviewed
Apr 2, 2020
jasonnutter
suggested changes
Apr 7, 2020
|
|
||
| // Poll token endpoint while (device code is not expired AND operation has not been cancelled by | ||
| // setting CancellationToken.cancel = true). POST request is sent at interval set by pollingIntervalMilli | ||
| let intervalId: ReturnType<typeof setTimeout>; |
There was a problem hiding this comment.
This can be a const defined inside the Promise.
| clearInterval(intervalId); | ||
| reject(ClientAuthError.createDeviceCodeExpiredError()); | ||
|
|
||
| } else { |
There was a problem hiding this comment.
Early returns might make this try bit more readable.
| const fs = require('fs'); | ||
|
|
||
| // Cookie life calculation (hours * minutes * seconds * ms) | ||
| const COOKIE_LIFE_MULTIPLIER = 24 * 60 * 60 * 1000; |
There was a problem hiding this comment.
Can you add the units to the name? e.g. COOKIE_LIFE_MS
| cookieStr += `expires=${expireTime};`; | ||
| } | ||
|
|
||
| document.cookie = cookieStr; |
There was a problem hiding this comment.
document doesn't exist in node, so I don't think you need the cookie logic.
jasonnutter
approved these changes
Apr 9, 2020
…checks [msal-node] Switch strictNullChecks: true for msal-node
[msal-node][msal-common] unit tests for msal-node changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation public APIs and implementation for authorization code flow and device code flow. Will add a separate PR for unit tests- won't merge this until that is out and reviewed.
Adds to msal-common:
response:
request:
Add to msal-node:
Adds to samples: