[msal-node][msal-common] unit tests for msal-node changes #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
approved these changes
Apr 6, 2020
sangonzal
requested review from
pkanher617,
jasonnutter,
DarylThayil and
tnorling
jasonnutter
reviewed
Apr 8, 2020
.gitignore
Outdated
| @@ -255,6 +255,9 @@ paket-files/ | |||
| .DS_Store | |||
| .DS_Store? | |||
|
|
|||
| # Visual Studio code | |||
| .vscode/ | |||
There was a problem hiding this comment.
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/.vscode/settings.json
I like having this in the repo because it we can use to setup things like linting, etc in the repo.
There was a problem hiding this comment.
Ok cool I'll remove this from .gitignore
…checks [msal-node] Switch strictNullChecks: true for msal-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding tests for #1434