[msal-node] Cache Lookup - 1: Logical keys for cache entities #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
changed the title
credential key generation to a common place
sameerag
changed the title
sangonzal
approved these changes
May 13, 2020
| * Generate Account Id key component as per the schema: <home_account_id>-<environment> | ||
| */ | ||
| generateRealm(): string { | ||
| return (this.realm || "").toLowerCase(); |
There was a problem hiding this comment.
I think empty space is used in multiple places, consider adding it to the constants file
There was a problem hiding this comment.
+1 for EMPTY_STRING constant
…arams and avoid null params
pkanher617
reviewed
May 27, 2020
| /** | ||
| * Generate Account Id key component as per the schema: <home_account_id>-<environment> | ||
| */ | ||
| generateAccountId(): string { |
There was a problem hiding this comment.
Can these be used as utils for cache lookup (i.e. generate keys for looking up a specific cred)?
There was a problem hiding this comment.
So generating accountId for an account object instance should be separate from generating it from a set of values. I will try coming up with common code as needed, for now I added static helpers in CacheHelper.ts in a later PR to address this. Point noted though.
pkanher617
approved these changes
May 27, 2020
sameerag
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-browser
[msal-node] Cache Lookup - 3: Msal node cache response
…/AzureAD/microsoft-authentication-library-for-js into msal-node-cache-lookup-interface
tnorling
approved these changes
Jun 3, 2020
[msal-node] Cache Lookup - 2: Save, lookup and delete entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates
AccountIdandCredentialIdas a part of theCredentialEntityandAccountEntitywhich will be later used in looking up cache elements as needed.Context :
Schema
AccountandCredentialcache has the below schema for keys:But to tie up a
CredentialwithAccount, the keys are logically divided as follows:Logical key components
Credential