Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node cache interface #1801

Merged
merged 2 commits into from Jun 23, 2020
Merged

Node cache interface #1801

merged 2 commits into from Jun 23, 2020

Conversation

sangonzal
Copy link
Contributor

Duplicate of #1687

Because of the recent significant changes to the cache code, I found it easier to just port the changes one by one to a new branch off dev instead of resolving merge conflicts.

@sangonzal sangonzal added the msal-node Related to msal-node package label Jun 19, 2020
@github-actions github-actions bot added msal-common Related to msal-common package samples Related to the samples apps for the library. labels Jun 19, 2020
@coveralls
Copy link

coveralls commented Jun 19, 2020

Coverage Status

Coverage decreased (-0.01%) to 76.988% when pulling f5a23a9 on node-cache-interface into 25d53da on dev.

Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. You can address the "CacheManager" name change and usage of "any" in a later PR IMO.

lib/msal-node/src/cache/CacheManager.ts Outdated Show resolved Hide resolved
lib/msal-node/src/cache/CacheManager.ts Outdated Show resolved Hide resolved
lib/msal-node/src/cache/CacheManager.ts Outdated Show resolved Hide resolved
lib/msal-node/src/cache/CacheManager.ts Outdated Show resolved Hide resolved
lib/msal-node/src/cache/CacheManager.ts Outdated Show resolved Hide resolved
@sangonzal sangonzal merged commit d891c49 into dev Jun 23, 2020
@sangonzal sangonzal deleted the node-cache-interface branch July 17, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants