Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry #3: Implement Telemetry in msal-node #1921
Telemetry #3: Implement Telemetry in msal-node #1921
Changes from 2 commits
ebbe74f
eb28059
7dc2daf
da6bede
d2b1807
19549ee
75cb78e
561bdfe
58bc4af
4cf4985
8888eb2
c970122
078d413
f1cf9a0
24ed043
c5245aa
f3c6baa
4f37e2e
9de6d65
f3badab
fbe5af9
31dfac1
2d40274
3b48482
f0ba824
7d760ac
1872900
01897d5
1afb052
0475b8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the catch is always telemetry initialization error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not. The catch is for any error that occurs in the flow so that Telemetry can properly cache it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they no API ids for confidential clients? Are we adding it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the callout. Confidential Client wasn't built out yet when this PR was first put up. Will add.