Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-node][msal-common] Add device code response in DeviceCodeClient.ts #1947

Merged
merged 9 commits into from
Jul 20, 2020
Merged

[msal-node][msal-common] Add device code response in DeviceCodeClient.ts #1947

merged 9 commits into from
Jul 20, 2020

Conversation

sameerag
Copy link
Member

This PR adds:

  • response handler for Device Code flow
  • updates extension package for tests

@sameerag sameerag self-assigned this Jul 14, 2020
@github-actions github-actions bot added msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library. labels Jul 14, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 81.601% when pulling 886c407 on msal-node-devicecode-response into 93f09d3 on dev.

@sameerag sameerag merged commit 32328bb into dev Jul 20, 2020
@sameerag sameerag mentioned this pull request Jul 20, 2020
Closed
3 tasks
@sameerag sameerag deleted the msal-node-devicecode-response branch July 20, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangonzal sangonzal sangonzal approved these changes

@jo-arroyo jo-arroyo jo-arroyo approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jasonnutter jasonnutter Awaiting requested review from jasonnutter

@jmckennon jmckennon Awaiting requested review from jmckennon

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees

@sameerag sameerag

Labels
msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sameerag @coveralls @sangonzal @jo-arroyo @pkanher617