Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-browser] Add SilentRequest.ts #1964

Merged
merged 4 commits into from Jul 16, 2020
Merged

[msal-browser] Add SilentRequest.ts #1964

merged 4 commits into from Jul 16, 2020

Conversation

pkanher617
Copy link
Contributor

This PR adds a SilentRequest object that is used for the acquireTokenSilent() API. Also fixes the comments in for each of the request objects.

@pkanher617 pkanher617 changed the base branch from dev to fix-silent-default-scopes July 15, 2020 00:47
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jul 15, 2020
tnorling
tnorling approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we also wrap the request object for ssoSilent since we're now wrapping the requests for all the other APIs? Would be better to do it now than later.

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jul 15, 2020
sameerag
sameerag approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. One comment: For consistency should we add:

export type SsoRequest = AuthorizationUrlRequest;

@pkanher617 pkanher617 merged commit 3a6c4c5 into fix-silent-default-scopes Jul 16, 2020
@pkanher617 pkanher617 linked an issue Jul 16, 2020 that may be closed by this pull request
redirectUri not available on SilentFlowRequest #1951
Closed
13 tasks
@pkanher617 pkanher617 deleted the add-silent-request branch August 1, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo

@hectormmg hectormmg Awaiting requested review from hectormmg

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redirectUri not available on SilentFlowRequest
4 participants
@pkanher617 @jasonnutter @tnorling @sameerag