-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msal-browser] Add SilentRequest.ts #1964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we also wrap the request object for ssoSilent
since we're now wrapping the requests for all the other APIs? Would be better to do it now than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. One comment: For consistency should we add:
export type SsoRequest = AuthorizationUrlRequest;
This PR adds a SilentRequest object that is used for the
acquireTokenSilent()
API. Also fixes the comments in for each of the request objects.