[msal-browser] Add negative offset value prevention for popup windows #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectormmg
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
pkanher617,
sameerag and
tnorling
as code owners
jasonnutter
reviewed
Jul 16, 2020
…stead of just wrapping the offset
pkanher617
approved these changes
Jul 16, 2020
tnorling
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents PopUp window position offsets from being negative by using
Math.max()in order to make the top and left offsets 0 if they are negative immediately before they are added to the calculated position.Fixes #1928