[msal-browser] Fix state mismatch error due to encoding #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
approved these changes
Jul 29, 2020
sameerag
approved these changes
Jul 30, 2020
|
Hi all, it appears that this PR will fix an issue my team is currently having with MSAL. We're not sure what sort of release cadence you are planning for with 2.0. What sort of timeline should we expect for when this fix will be available through NPM? |
tnorling
approved these changes
Jul 30, 2020
…tion-library-for-js into browser-state-mismatch-fix
tnorling
requested review from
DarylThayil,
jasonnutter,
jmckennon and
hectormmg
as code owners
8 tasks
8 tasks
13 tasks
pkanher617
modified the milestones:
@azure/msal-browser@2.1.0 Release,
@azure/msal-browser@2.0.1 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the state that is returned from the server is being mutated by their base64 encoding mechanism, which is different to our encoding mechanism, causing a state mismatch error. This PR attempts to provide a temporary solution by decoding the state strings before comparing the response state and cached state. More investigation and communication with the server team may be necessary to figure out why this mutation occurs.
This PR addresses issue #2019 .