Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function signatures for getAllAccounts and getAccountByUsername #2059

Merged
merged 7 commits into from
Jul 30, 2020
Merged

Fix function signatures for getAllAccounts and getAccountByUsername #2059

merged 7 commits into from
Jul 30, 2020

Conversation

tnorling
Copy link
Collaborator

Addresses #2053

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jul 29, 2020
@tnorling tnorling linked an issue Jul 29, 2020 that may be closed by this pull request
Fix function signatures for getAllAccounts and getAccountByUsername #2053
Closed
8 tasks
@coveralls
Copy link

coveralls commented Jul 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 81.838% when pulling 5f50bde on Fix-function-signatures into 518320f on dev.

sameerag
sameerag reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: helps to add a little desc of the PR even if it is fixing a bug for readability

sameerag
sameerag approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on tests. Approved.

@tnorling tnorling merged commit 0ea84e2 into dev Jul 30, 2020
@aappddeevv
Copy link

Thanks for putting this in so quickly!

@tnorling tnorling deleted the Fix-function-signatures branch August 4, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@sameerag sameerag sameerag approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
@azure/msal-browser@2.0.1 Release
Development

Successfully merging this pull request may close these issues.

Fix function signatures for getAllAccounts and getAccountByUsername
6 participants
@tnorling @coveralls @aappddeevv @jasonnutter @pkanher617 @sameerag