Address msal-node tsdx warning #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Aug 27, 2020
| import { Constants as NodeConstants } from './../utils/Constants'; | ||
| import { TokenCache } from '../cache/TokenCache'; | ||
| import { ClientAssertion } from "../client/ClientAssertion"; | ||
| const pjson = require("../../package.json"); |
There was a problem hiding this comment.
I thought we are avoiding require except in tests.
There was a problem hiding this comment.
Hmm then we may need to think of something because we can't import package.json from outside the root without using require
There was a problem hiding this comment.
I think it's ok for this scenario. Did some testing and there isn't any way this will work otherwise currently because tsdx has issues with . as the rootDir. This is one reason I don't think we should have used tsdx.
There was a problem hiding this comment.
So even adding a @ts-ignore in order to import, silently changes the rootDir back to ./ in the background. We'll move forward with the require for now and revisit later
sangonzal
approved these changes
Aug 27, 2020
pkanher617
approved these changes
Aug 28, 2020
tnorling
requested review from
DarylThayil,
jasonnutter,
jmckennon and
jo-arroyo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses warning when building msal-node:
[tsdx]: Your rootDir is currently set to "./". Please change your rootDir to "./src". TSDX has deprecated setting tsconfig.compilerOptions.rootDir to "./" as it caused buggy output for declarationMaps and occassionally for type declarations themselves. You may also need to change your include to remove "test", which also caused declarations to be unnecessarily created for test files.Also hopefully fixes intermittent build error:
EBUSY: resource busy or locked, copyfile 'D:\a\1\s\lib\msal-node\dist\src\utils\NetworkUtils.d.ts' -> 'D:\a\1\s\lib\msal-node\dist\utils\NetworkUtils.d.ts'