Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger messages for cache misses #4199

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Add logger messages for cache misses #4199

merged 5 commits into from
Nov 1, 2021

Conversation

tnorling
Copy link
Collaborator

  • Adds log messages with the reason for a cache miss
  • Moves early return for forceRefresh and claims before the actual cache lookup occurs

@github-actions github-actions bot added the msal-common Related to msal-common package label Oct 28, 2021
@tnorling tnorling added this to the @azure/msal-common@5.0.2 milestone Oct 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #4199 (a583aa9) into dev (51669ad) will increase coverage by 2.30%.
The diff coverage is 95.23%.

Flag Coverage Δ
msal-angular 96.39% <100.00%> (+0.08%) ⬆️
msal-browser 87.76% <ø> (ø)
msal-common 85.23% <90.90%> (+0.02%) ⬆️
msal-core ?
msal-node 81.93% <ø> (ø)
msal-react 94.19% <ø> (ø)
Impacted Files Coverage Δ
lib/msal-common/src/client/SilentFlowClient.ts 89.09% <90.90%> (+1.09%) ⬆️
lib/msal-angular/src/msal.guard.ts 90.14% <100.00%> (+0.74%) ⬆️
lib/msal-core/src/ClientInfo.ts
lib/msal-core/src/authority/AuthorityFactory.ts
lib/msal-core/src/utils/TokenUtils.ts
lib/msal-core/src/telemetry/DefaultEvent.ts
lib/msal-core/src/ScopeSet.ts
...sal-core/src/error/InteractionRequiredAuthError.ts
lib/msal-core/src/utils/TimeUtils.ts
lib/msal-core/src/AuthResponse.ts
... and 35 more

@tnorling tnorling merged commit 41ac7a8 into dev Nov 1, 2021
@tnorling tnorling deleted the cache-miss-logs branch November 1, 2021 21:30
@ghost
Copy link

ghost commented Nov 2, 2021

🎉@azure/msal-common@v5.1.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants