Instrument account type #7049
Merged
Instrument account type #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
Robbie-Microsoft
as code owners
github-actions
bot
added
msal-browser
tnorling
reviewed
Apr 23, 2024
| ): "AAD" | "MSA" | "B2C" | undefined { | ||
| const idTokenClaims = account?.idTokenClaims; | ||
| if (idTokenClaims?.tfp || idTokenClaims?.acr) { | ||
| return "B2C"; |
There was a problem hiding this comment.
Do we ever expect this condition to be hit when collecting telemetry? AFAIK no 1P apps are using B2C
There was a problem hiding this comment.
We do not expect this condition to be hit for 1P apps. However, i would prefer to handle this scenario for 3P apps injecting custom performance clients.
tnorling
approved these changes
Apr 23, 2024
konstantin-msft
force-pushed
the
instrument_account_type
branch
from
4e68c33
to
414a24f
Compare
konstantin-msft
force-pushed
the
instrument_account_type
branch
from
414a24f
to
b440b08
Compare
hectormmg
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE Account type is instrumented before (if exists) and after network/cache call to make it defined for failed requests when no response is returned.