Enable Python 3.8 in test automation #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik-me
reviewed
Oct 15, 2019
| @@ -11,6 +11,9 @@ matrix: | |||
| - python: 3.7 | |||
There was a problem hiding this comment.
- python: 3.7 [](start = 4, length = 13)
remove ?
There was a problem hiding this comment.
No, we don't want to remove any of the previous versions. We want the test runs to cover all major Python versions, as seen here.
does new options need to be added here? If so are those needed in the include section? Refers to: .travis.yml:6 in eb80b95. [](commit_id = eb80b95, deletion_comment = False) Answered inline to keep Q&A stay together: It is indeed a weird thing that this test infrastructure requires the newer Python versions (3.7, 3.8) to be configured in a different way. But again, as long as it covers all Python versions that we need, it is fine. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8.0 has been released yesterday. Now we include it in our test automation matrix.