Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADFS 2019 on-prem test cases #142

Merged
merged 1 commit into from Jan 23, 2020
Merged

ADFS 2019 on-prem test cases #142

merged 1 commit into from Jan 23, 2020

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Jan 14, 2020

With these test cases, we will be able to address #132

@rayluo rayluo added this to Pending Approval by Reviewer in MSAL Python Board Jan 15, 2020
@rayluo rayluo moved this from Pending Approval by Reviewer to In progress in MSAL Python Board Jan 15, 2020
rayluo
rayluo commented Jan 23, 2020
View reviewed changes
Copy link
Collaborator Author

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-note: although we did not conduct a full review for this PR, but giving that these test cases are all passed and the new tests are self-explanatory, we merge this PR now to prepare for an upcoming release.

@rayluo rayluo merged commit 113a437 into dev Jan 23, 2020
MSAL Python Board automation moved this from In progress to Done Jan 23, 2020
@rayluo rayluo deleted the refactor-e2e-tests branch January 23, 2020 18:36
@rayluo rayluo mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidnya13 abhidnya13 Awaiting requested review from abhidnya13

Assignees
No one assigned
Labels
None yet
Projects
MSAL Python Customer Trust
Archived in project
MSAL Python Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rayluo