Release 1.2.0 #177
Merged
Release 1.2.0 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MSAL Python 1.1.0 back to dev branch
conf.py imports the version from the local module, so it needs to have the
directory in the python path, otherwise it fails with:
$ sphinx-apidoc -f -e -o docs/api msal
Creating file docs/api/msal.application.rst.
Creating file docs/api/msal.authority.rst.
Creating file docs/api/msal.exceptions.rst.
Creating file docs/api/msal.mex.rst.
Creating file docs/api/msal.token_cache.rst.
Creating file docs/api/msal.wstrust_request.rst.
Creating file docs/api/msal.wstrust_response.rst.
Creating file docs/api/msal.rst.
Creating file docs/api/msal.oauth2cli.assertion.rst.
Creating file docs/api/msal.oauth2cli.authcode.rst.
Creating file docs/api/msal.oauth2cli.oauth2.rst.
Creating file docs/api/msal.oauth2cli.oidc.rst.
Creating file docs/api/msal.oauth2cli.rst.
Creating file docs/api/modules.rst.
$ make -C docs man
make: Entering directory '/home/bluca/git/microsoft-authentication-library-for-python/docs'
Running Sphinx v1.8.4
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/sphinx/config.py", line 368, in eval_config_file
execfile_(filename, namespace)
File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line 150, in execfile_
exec_(code, _globals)
File "/home/bluca/git/microsoft-authentication-library-for-python/docs/conf.py", line 27, in <module>
from msal import __version__ as version
ModuleNotFoundError: No module named 'msal'
make: *** [Makefile:19: man] Error 2
Add source root dir to python path in docs/conf.py
Minor change
Defines a minimalistic http interface. Earlier today, Abhi and I had a line-by-line discussion on this already.
Fix a merging error introduced in last commit
Specifying and validating nonce in auth code flow
Bump version number
abhidnya13
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the sub-PRs included in this release has been tested, reviewed and approved in their individual PR. The purpose of this all-in-one release PR is to organize the release process. Please review/proof-read the following release notes.
Release Notes:
nonceparameter is provided in bothget_authorization_request_url(..., nonce=...)andacquire_token_by_authorization_code(..., nonce=...)methods, so that you can use them to mitigate replay attacks, per OIDC specs. (Missing nonce parameter when requesting id_tokens #128, Specifying and validating nonce in auth code flow #173).If you prefer to, you can install this branch for your smoke testing: