Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding client assertion type #35

Merged
merged 1 commit into from Apr 11, 2019
Merged

Adding client assertion type #35

merged 1 commit into from Apr 11, 2019

Conversation

abhidnya13
Copy link
Contributor

  • Client assertion type was not set in configuration of client for certificate credential flow.
  • This PR adds the client assertion type.

@abhidnya13 abhidnya13 requested a review from rayluo April 11, 2019 06:55
@rayluo
Copy link
Collaborator

rayluo commented Apr 11, 2019

Good catch! Thanks for burning your midnight oil. I'll take a close look tomorrow.

Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix a regression that happened since 0.2.0. We will ship it in next release!

@rayluo rayluo merged commit 16db2d7 into dev Apr 11, 2019
@rayluo rayluo deleted the client_cert_flow_changes branch April 11, 2019 18:24
@abhidnya13 abhidnya13 mentioned this pull request Apr 16, 2019
jiasli pushed a commit to jiasli/microsoft-authentication-library-for-python that referenced this pull request Mar 1, 2021
Merge release 0.1.2 back to dev branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants