Http cache #379
Merged
Http cache #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
reviewed
Jul 8, 2021
rayluo
force-pushed
the
http-cache
branch
3 times, most recently
from
e35b4b8
to
20b65d9
Compare
chlowell
reviewed
Jul 15, 2021
rayluo
force-pushed
the
http-cache
branch
5 times, most recently
from
5cf9b9b
to
d4c2fb6
Compare
chlowell
reviewed
Aug 10, 2021
WIP: Not runnable scratch Doodle Gear towards a different direction WIP Rename to ControllableCache Use new ControllableCache Proof-of-Concept Support runtime storage Rename to IndividualCache Documentation draft Enable http_decorate Precise KeyError message
Decorate the http_client for http_cache behavior Wrap http_client instead of decorate it Rename to throttled_http_client.py Refactor and change default retry-after delay to 60 seconds ThrottledHttpClient test case contains params
Merged
This was referenced Sep 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the cache behavior on http layer. Such a cache is used internally to cache some http responses for performance optimization. In particular, when such an optimization happens on http 429/5xx with Retry-After header, it is a protection also known as "throttling" in MSAL parlance. This behavior resolves #159.
Such an http cache behavior is always enabled. Currently, the http cache is in-memory only.