Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The more generic common endpoint can now support Device Flow for MSA #91

Merged
merged 1 commit into from Oct 16, 2019

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Sep 4, 2019

Since recently, the Microsoft Identity platform supports Device Flow for personal accounts (MSA) too.

In this PR we adjust the comment, which is a mini-sample in its own to demonstrate "how to configure this sample".

Manual test shows that:

  • Using "common" endpoint can perform device flow to acquire a token for my corp account. So this change is at least as good as the previous "organizations" endpoint.
  • Using "common" endpoint can also perform device flow for a Hotmail account. It seems the end user would need to type his/her password and redo the consent every time, though.

@rayluo rayluo changed the title The more generic common can now support DF for MSA The more generic common endpoint can now support Device Flow for MSA Sep 4, 2019
@jmprieur
Copy link

jmprieur commented Sep 5, 2019

@rayluo : I would wait a bit before merging, as it does not seem to be deployed everywhere (it does not work yet for me. I still get the following error:
AADSTS90133: Device Code flow is not supported under /common or /consumers endpoint.

@rayluo
Copy link
Collaborator Author

rayluo commented Oct 16, 2019

@jmprieur , now the MSAL .Net issue 728 has been closed, can we merge this PR into MSAL Python too?

@jmprieur
Copy link

Sure @rayluo go ahead. This works now

@rayluo rayluo merged commit 47614bd into dev Oct 16, 2019
@rayluo rayluo deleted the device-flow-for-msa-accounts branch October 16, 2019 17:11
@rayluo rayluo mentioned this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants