Allow token exchange URL configuration #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyangsong
commented
Apr 17, 2024
src/Microsoft.Identity.Web.Certificate/SignedAssertionFromManagedIdentityCredentialLoader.cs
Show resolved
Hide resolved
jmprieur
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Looks like a good start @kellyyangsong
I've left a couple of comments, and provided an explanation
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/SignedAssertionFromManagedIdentityCredentialLoader.cs
Show resolved
Hide resolved
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
kellyyangsong
commented
Apr 18, 2024
pmaytak
reviewed
Apr 18, 2024
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Show resolved
Hide resolved
pmaytak
reviewed
Apr 18, 2024
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
…microsoft-identity-web into kellysong/msi-fic-devex
jmprieur
approved these changes
Apr 18, 2024
jennyf19
approved these changes
Apr 18, 2024
kellyyangsong
added a commit
that referenced
this pull request
Apr 18, 2024
* initial commit adding configurable token exchange url * Apply suggestions from code review Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * use abstractions 5.2.0 * separate ctor overload * add msi fic support to changelog --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
kellyyangsong
added a commit
that referenced
this pull request
Apr 18, 2024
* Allow token exchange URL configuration (#2767) * initial commit adding configurable token exchange url * Apply suggestions from code review Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * use abstractions 5.2.0 * separate ctor overload * add msi fic support to changelog --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * bring back abstractions 5.2.0! --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2749