-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow token exchange URL configuration #2767
Conversation
src/Microsoft.Identity.Web.Certificate/SignedAssertionFromManagedIdentityCredentialLoader.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start @kellyyangsong
I've left a couple of comments, and provided an explanation
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/SignedAssertionFromManagedIdentityCredentialLoader.cs
Show resolved
Hide resolved
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
Outdated
Show resolved
Hide resolved
…microsoft-identity-web into kellysong/msi-fic-devex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kellyyangsong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need to also got into rel/v2 as a cherry-pick (we will release from rel/v2)
* initial commit adding configurable token exchange url * Apply suggestions from code review Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * use abstractions 5.2.0 * separate ctor overload * add msi fic support to changelog --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
* Allow token exchange URL configuration (#2767) * initial commit adding configurable token exchange url * Apply suggestions from code review Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * use abstractions 5.2.0 * separate ctor overload * add msi fic support to changelog --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> * bring back abstractions 5.2.0! --------- Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
Fixes #2749