Generate VPI files in the same dir with Verilog #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated Verilog files are placed in the -vdir directory or, if no -vdir is specified, in the same directory as the source file being compiles. VPI wrapper files are also placed in the -vdir, but if no -vdir is specified, they were being placed in the current directory (where BSC is invoked). These should be consistent, so the location for VPI wrappers is fixed to match the generated Verilog.
Previously, the linking stage assumed that VPI wrapper files were in the vdir or (if no vdir) the current directory (where BSC is invoked). This probably explains why the compile stage had been changed to put the VPI wrappers in the current directory (see previous commit, which reverts that change). BSC needs to support linking where VPI wrappers are found in various directories -- both because of the change to the compile stage (to put the VPI wrappers in the various source directories) but also because the files may not have been compiled with the same vdir. Specificaly, users will want to compile files into a library, that can be used with multiple designs; those files should be able to sit in their own directory tree. If the library contains imported C functions, then VPI wrapper files will be in the directory tree, and the BSC link stage will need to be able to find them. Now that the compile stage is putting VPI wrapper files in the same location with Verilog files, the linking stage can use the Verilog search path to find them. This makes that change and adds tests.
|
I have pushed a commit which also changes the BSC link step, to search for VPI wrapper files in the Verilog search path. This allows BSC to link designs that pull in previously-compiled code from various places, which might each have their own VPI wrappers -- where previously BSC expected the wrappers to be in one directory (either the link step's vdir or the current directory where the link step is invoked). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue reported in Discussion #575.
Generated Verilog files are placed in the
-vdirdirectory or, if no-vdiris specified, in the same directory as the source file being compiles. VPI wrapper files are also placed in the-vdir, but if no-vdiris specified, they were being placed in the current directory (where BSC is invoked). These should be consistent, so the location for VPI wrappers is fixed to match the generated Verilog.Simple testing is added to
bsc.options.