Fix the desugaring of struct update #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quark17
force-pushed
the
tcheck-cstructupd
branch
from
98883c2
to
ac9661f
Compare
This addresses GitHub issue 628, by fixing the desugaring of struct updates during typecheck. It mostly fixes issues around qualified field names, which is only allowed in BH, but it also fixes the position of the fields in the new expression, which might improve position information for errors in BSV. Test cases are added for both qualified and unqualified field names in struct update, construction, and pattern matching. Further tests are added for incorrect qualifiers and duplicate field names with the same base name (such as qualified and unqualified). The typecheck of CStruct had been fixed in 2006 to account for qualifiers (in most situations), but similar code in the typecheck of CStructUpd that needed the same fix was overlooked, and typecheck of CPstruct was even further behind. These are all updated, with additional comments and some improved variable names.
quark17
force-pushed
the
tcheck-cstructupd
branch
from
ac9661f
to
56be4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses GitHub issue #628. It mostly fixes issues around qualified field names, which is only allowed in BH, but it also fixes the position of the fields in the new expression, which might improve position information for errors in BSV. Test cases are added, for struct update as well as struct construction and pattern matching.