[suggestion] Use '+' symbol in maximize window button

[ghost]

Hello, thank you for these perfect themes!

I would like to suggest use of '+' instead of the two triangles in the maximize button (hover).
1- because the two arrows stay the same even if window is maximized which is incoherent
2- because arrows are pointing to the right even for people who use buttons at left (same as MacOS)
3- '+' is more neutral and is coherent in any scenario
4- Two arrows are often met as a "fullscreen" rather than as a "maximize" meaning
5- Not sure about this one but if I remember well it's what original Mac OSX themes use

[dominichayesferen]

Yeah, + = Maximise, <> = Full Screen

[Elbullazul]

Does mac act like this? If not, I can provide alternate PNGs but would keep the macOS style buttons

[ghost]

Confirmed: macOS doesn't use double arrows but a '+'. Look here (scroll down).
And as we said double arrows are more for "fullscreen" than "maximize".

Add the other points from my first comment and I think that we have good reasons to see a '+' in this button.

PS: of course I speak of button while hovering, normal state is just plain color.

[Elbullazul]

Ok, will commit corrections soon, thanks for helping us improve this theme!

[ghost]

No problem, it's always a pleasure to help improving things that I like :p

Thank you guys!

[ghost]

Hello, are you still working on it?

[Elbullazul]

Haven't had time, had to first upgrade the pc and install Linux on it. Maybe I'll do it this week Le 5 mars 2018 00:58, "DarthWound" <notifications@github.com> a écrit :

…

Hello, are you still working on it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOmgiXREOXXnrknIT3wm66Lc7fV0s3Fmks5tbNQGgaJpZM4RddJC> .

[dominichayesferen]

@DarthWound There again, I just thought of something: Personally, I always found it weird because the + didn't seem to actually maximise the window, but instead change it to a second user-defined size.

[ghost]

Well, in macOS, behaviour is a bit different than on usual GNU/Linux window managers or on Windows. It changes window size to fit content, so often the result is that window is maximized but not always. To maximize a window you have to hit Option key while clicking on the +.

I'm not a macOS user, only GNU/Linux, but I'm quite upset to see that 99,9% of themes are copying an old "fullscreen" button that was introduced in Yosemite and disappeared since Sierra (it means that this "fullscreen" button was only there during 2 versions of macOS).

[Elbullazul]

thanks to both, corrective has been pushed, will soon commit to macOS Dark for same corrections

[ghost]

Well done, thank you!