Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse BAG2 leveringsdocument instead of relying on filename #1372

Merged
merged 5 commits into from
Apr 13, 2022

Conversation

matthijsln
Copy link
Member

@matthijsln matthijsln commented Apr 8, 2022

BRMO-153

The filename is still considered first so when checking a big list of available mutaties whether they should be applied it does not require extracting the leveringsdocument for each one, leading to a lot of partial HTTP requests. The fallback if the name is not in a known format is to parse the leveringsdocument from the ZIP.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1372 (07fad8a) into master (b5aa174) will decrease coverage by 0.02%.
The diff coverage is 38.05%.

@@             Coverage Diff              @@
##             master    #1372      +/-   ##
============================================
- Coverage     36.13%   36.11%   -0.03%     
- Complexity      809     1188     +379     
============================================
  Files           407      407              
  Lines         18793    18840      +47     
  Branches       1878     1880       +2     
============================================
+ Hits           6791     6804      +13     
- Misses        11401    11430      +29     
- Partials        601      606       +5     
Impacted Files Coverage Δ
.../b3p/brmo/bag2/loader/cli/BAG2MutatiesCommand.java 0.00% <0.00%> (ø)
...va/nl/b3p/brmo/bag2/loader/cli/BAG2LoaderMain.java 38.13% <7.69%> (+0.16%) ⬆️
.../java/nl/b3p/brmo/bag2/loader/BAG2LoaderUtils.java 50.44% <51.61%> (-19.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5aa174...07fad8a. Read the comment docs.

@matthijsln matthijsln force-pushed the BRMO-153-parse-leveringsdocument branch from d1830a2 to 73687bd Compare April 8, 2022 14:19
@matthijsln matthijsln force-pushed the BRMO-153-parse-leveringsdocument branch from 73687bd to 33250dc Compare April 8, 2022 15:49
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toch kans gezien om regex en jaxb te gebruiken 😆

@mprins mprins added this to the 2.2.2 milestone Apr 13, 2022
@mprins mprins merged commit 6fd61f4 into master Apr 13, 2022
@mprins mprins deleted the BRMO-153-parse-leveringsdocument branch April 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants