Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nhr-loader: add dedicated NHRException, use in service #1411

Merged
merged 1 commit into from
May 11, 2022

Conversation

puckipedia
Copy link
Contributor

Als een ongeldig KVK nummer gebruikt wordt, wordt deze nu voor eeuwig opnieuw geprobeerd. Deze PR zorgt ervoor dat de foutmeldingen van de KVK API correct teruggestuurd worden, en dat de requests niet opnieuw geprobeerd worden op ongeldige/onbekende KVK nummers.

This is necessary for avoiding retries of invalid KVK nummers.
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1411 (5eba9f8) into master (a96af32) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1411   +/-   ##
=========================================
  Coverage     35.54%   35.54%           
  Complexity      809      809           
=========================================
  Files           410      410           
  Lines         19160    19171   +11     
  Branches       1912     1914    +2     
=========================================
+ Hits           6811     6815    +4     
- Misses        11738    11747    +9     
+ Partials        611      609    -2     
Impacted Files Coverage Δ
...src/main/java/nl/b3p/brmo/service/jobs/NHRJob.java 0.00% <0.00%> (ø)
...nl/b3p/brmo/util/http/HttpSeekableByteChannel.java 69.87% <0.00%> (+1.20%) ⬆️
...nl/b3p/brmo/bgt/download/api/DownloadApiUtils.java 76.47% <0.00%> (+8.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96af32...5eba9f8. Read the comment docs.

@mprins mprins merged commit 5df2587 into B3Partners:master May 11, 2022
@mprins mprins added this to the 2.3.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants