Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BAG2 slow views by using common objectid sequence #1441

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

matthijsln
Copy link
Member

BRMO-192

  • objectid sequence for all objectid columns so rows from tables can be combined in view but row number does not need to be used, speeding up non-materialized views
  • reverse geometrie_centroid and geometrie columns, so on-the-fly calculated column is not used for TailorMap geometry queries

Update instructions should include that the BAG2 views should be recreated using the scripts (208_bag2_views.sql and 209_bag2_rsgb_views.sql) that get included in the installation scripts.

@matthijsln matthijsln requested a review from mprins June 8, 2022 16:16
@matthijsln matthijsln force-pushed the BRMO-192-BAG2-slow-views branch 2 times, most recently from 73048d5 to 121889a Compare June 9, 2022 08:53
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1441 (8fcf05a) into master (21700d1) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             master    #1441    +/-   ##
==========================================
  Coverage     35.90%   35.90%            
- Complexity      809     1190   +381     
==========================================
  Files           410      410            
  Lines         19196    19204     +8     
  Branches       1915     1917     +2     
==========================================
+ Hits           6892     6895     +3     
- Misses        11704    11707     +3     
- Partials        600      602     +2     
Impacted Files Coverage Δ
.../main/java/nl/b3p/brmo/bag2/schema/BAG2Schema.java 100.00% <ø> (ø)
...in/java/nl/b3p/brmo/sql/dialect/OracleDialect.java 77.41% <33.33%> (-4.73%) ⬇️
...n/java/nl/b3p/brmo/sql/dialect/PostGISDialect.java 78.94% <50.00%> (-7.72%) ⬇️
...va/nl/b3p/brmo/bag2/loader/cli/BAG2LoaderMain.java 52.24% <100.00%> (+0.19%) ⬆️
.../main/java/nl/b3p/brmo/sql/dialect/SQLDialect.java 41.17% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21700d1...8fcf05a. Read the comment docs.

@matthijsln matthijsln merged commit ed2e304 into master Jun 9, 2022
@matthijsln matthijsln deleted the BRMO-192-BAG2-slow-views branch June 9, 2022 10:36
@mprins mprins added this to the 2.3.1 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants