129 lcs plot

[vhirtham]

Changes

Describe changes in this PR

Related Issues

Closes #129

Checks

• updated CHANGELOG.md
• updated tests
• updated doc/
• update example/tutorial notebooks

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[vhirtham]

Here is a quick test script for the CSM plot function:

import matplotlib.pyplot as plt
import pandas as pd

from weldx import CoordinateSystemManager

csm = CoordinateSystemManager("root")

csm.create_cs("lcs 1", "root", coordinates=[2, 5, 6])
csm.create_cs_from_euler(
    "lcs 2",
    "root",
    sequence="z",
    angles=[0, 90, 270],
    degrees=True,
    coordinates=[[4, -2, 1], [-5, 6, 2], [3, 4, 2]],
    time=["2010-02-01", "2010-02-05", "2010-02-08"],
)

new_times = pd.date_range(start="2010-02-01", end="2010-02-8", freq="6H")

csm.plot_coordinate_systems(
    reference_system="root", time=new_times, show_axes=True, show_trace=True
)
plt.show()

It's really interesting to see the trajectories if you change the reference coordinate system in the plot function to "lcs 1" :D

[codecov]

Codecov Report

Merging #231 (ebc5ab1) into master (1b6ebc0) will increase coverage by 0.04%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   99.34%   99.39%   +0.04%     
==========================================
  Files          72       71       -1     
  Lines        3968     3942      -26     
==========================================
- Hits         3942     3918      -24     
+ Misses         26       24       -2     

Impacted Files	Coverage Δ
weldx/__init__.py	100.00% <ø> (ø)
weldx/geometry.py	99.05% <92.30%> (+0.32%)	⬆️
weldx/asdf/tags/weldx/core/geometry/__init__.py	100.00% <100.00%> (ø)
...eldx/asdf/tags/weldx/core/geometry/spatial_data.py	100.00% <100.00%> (ø)
weldx/transformations.py	99.39% <100.00%> (+<0.01%)	⬆️
weldx/utility.py	95.97% <100.00%> (-0.08%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6ebc0...ebc5ab1. Read the comment docs.

[pep8speaks]

Hello @vhirtham! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-24 10:59:38 UTC

[vhirtham]

do we add this back in before merging?

@CagtayFabry Not sure here. In this PR, adding pull_request double triggered the actions. So I removed it.

[marscher]

👍