Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wx shape syntax #537

Merged
merged 6 commits into from
Sep 17, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Sep 16, 2021

Changes

remove the : syntax option from wx_shape

Related Issues

as mentioned here

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/

@CagtayFabry CagtayFabry added the validation custom ASDF validators label Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #537 (c5620c1) into master (5e9e6d7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c5620c1 differs from pull request most recent head a0ac4f5. Consider uploading reports for the commit a0ac4f5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          93       93           
  Lines        5641     5641           
=======================================
  Hits         5366     5366           
  Misses        275      275           
Impacted Files Coverage Δ
weldx/asdf/validators.py 99.32% <100.00%> (ø)
weldx/asdf/file.py 97.69% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7065612...a0ac4f5. Read the comment docs.

@CagtayFabry CagtayFabry marked this pull request as ready for review September 16, 2021 20:13
@CagtayFabry CagtayFabry merged commit 872a476 into BAMWelDX:master Sep 17, 2021
@CagtayFabry CagtayFabry deleted the update_wx_shape_syntax branch September 17, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation custom ASDF validators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants