Some fixes for sai_display_rework #4
Conversation
OutputType Exe causes PrismApplication to show console
| { | ||
| "type": "BoolParameter", | ||
| "name": "UseTalkTarget", | ||
| "description": "Talker will target {target}" | ||
| } | ||
| ], | ||
| "description": "{target}: Talk {pram1}", |
There was a problem hiding this comment.
SAI is great, but it has a lot of edge cases and my goal was to support all of them as many as possible. For example, in case of SMART_ACTION_TALK (as far as I can see):
target == TARGET_NONE:
Self: Talk {pram1} to invoker
target is player:
Self: Talk {pram1} to {target}
useTalkTarget == true:
Self: Talk {pram1} to {target}
useTalkTarget == false:
{target}: Talk {pram1} to invoker
This is huge mess and in my option, it is a big mistake in TrinityCore, imagine writing it by hand in sql, pretty impossible to get desired result easily. What is more, this cannot be entirely moved to editor. Second condition target is player is dynamic, so in case of some targets, we don't know by the time of writing the script if the target will be player or not.
But we can implement description in other cases:
{targetid:choose(0):Self: Talk {pram1} to invoker|{pram3value:choose(0):{target}: Talk {pram1} to invoker|Self: Talk {pram1} to {target}}}```
| } | ||
| ], | ||
| "description": "{target}: Add quest {pram1}", | ||
| "description": "{target}: Offer/Add quest {pram1}", |
There was a problem hiding this comment.
{target}: {pram2value:choose(0):Add quest {pram1} to quest log|Offer quest {pram1}}
| }, | ||
| { | ||
| "type": "Parameter", | ||
| "name": "TargetsLimit" | ||
| } | ||
| ], | ||
| "description": "Self: Cast spell {pram1} on {target}", |
There was a problem hiding this comment.
Self: Cast spell {pram1} on{pram4value:choose(0):| random {pram4}} {target}
| } | ||
| ], | ||
| "description": "{target}: Set phase {pram1}", | ||
| "description": "{target}: Set/Remove phasegroup {pram1}", |
There was a problem hiding this comment.
{target}: {pram2value:choose(0):Remove|Add} phasegroup {pram1}
| { | ||
| "type": "Parameter", | ||
| "name": "Charges", | ||
| "description": "If 0 all charges are removed" | ||
| } | ||
| ], | ||
| "description": "{target}: {pram1value:choose(0):Remove all auras|Remove aura due to spell {pram1}}", |
There was a problem hiding this comment.
{target}: {pram1value:choose(0):Remove all auras|Remove{pram2value:choose(0):| {pram2} charges of} aura due to spell {pram1}}
| "name_readable": "Invoker Cast", | ||
| "uses_target": true, | ||
| "target_is_source": true, | ||
| "implicit_source": false |
| @@ -78,6 +83,10 @@ | |||
| "type": "BoolParameter", | |||
| "name": "Only to self", | |||
| "description": "True - only target will hear the sound, false - everyone in visibility range will hear the sound" | |||
| }, | |||
| { | |||
| "type": "Paramter", | |||
| }, | ||
| { | ||
| "type": "Paramter", | ||
| "name": "Distance" | ||
| } | ||
| ], | ||
| "description": "{target}: Play sound {pram1} to {pram2value:choose(0):every player in visibility range of {target}|{target}}", |
There was a problem hiding this comment.
{target}: Play {pram2value:choose(0):direct|distance} sound {pram1} to {pram2value:choose(0):every player in visibility range of {target}|{target}
| }, | ||
| { | ||
| "type": "Parameter", | ||
| "name": "ForeRespawnTimer" | ||
| } | ||
| ], | ||
| "description": "{target}: Despawn {pram1value:choose(0):instantly|in {pram1} ms}", |
There was a problem hiding this comment.
{target}: Despawn {pram1value:choose(0):instantly|in {pram1} ms}{pram2value:choose(0):| respawn in {pram2} seconds}
| } | ||
| ], | ||
| "description": "Plays randomly one of: {pram1}, {pram2}, {pram3}, {pram4}, {pram5} {pram6value:choose(0):of all|only self}", | ||
| "description": "Plays randomly one of: {pram1}, {pram2}, {pram3}, {pram4} {pram6value:choose(0):of all|only self}", |
There was a problem hiding this comment.
They started using target, so
"description": "{target}: Play random {pram6value:choose(0):direct|distance} sound one of: {pram1}, {pram2}, {pram3}, {pram4} {pram6value:choose(0):of all|only self}",
"name_readable": "Play random sound",
"uses_target": true,
"target_is_source": true,
"implicit_source": false
|
actually i just realized... How should we handle this ? |
Tbh I have no idea for now, I didn't touch cata+ cores so I know nothing about dynamic spawn system and it's possible impact on SAI for TC(especially TC as I worked on authored, rewritten SAI). Maybe @BAndysc will want to think about it, I am too busy with work and diploma on uni. |
| } | ||
| ], | ||
| "description": "{target}: Add quest {pram1}", | ||
| "description": "{target}: {pram2value:choose(0):Add quest {pram1} to quest log|Offer quest {pram1}}", |
There was a problem hiding this comment.
oops, sorry, yesterday I made a mistake here, it is the opposite: choose(0) - offer quest, otherwise - add to questlog
{target}: {pram2value:choose(0):Offer quest {pram1}|Add quest {pram1} to quest log}
Actually, there are few more actions with different parameters for 335, 434 and 825. We might add
the impact is that those actions are not present on bfa TC :) |
BAndysc
force-pushed
the
sai_display_rework
branch
2 times, most recently
from
94f19ab
to
f0cc700
Compare
68d4dfa broke parameter loading instead of fixing it
9a5c8c3 Changing OutputType to Exe instead of WinExe caused the console to stay appeared all time, thinking about this, it only makes sense in DEBUG mode.
a62dff1 Makes the console disappear right on initialize if compiled in Release
There is no condition type SMART_ACTION in TC, so we can just hide this part in editParameter