Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/posts and attachments #116

Merged
merged 20 commits into from
Oct 30, 2023
Merged

Feat/posts and attachments #116

merged 20 commits into from
Oct 30, 2023

Conversation

svituz
Copy link
Contributor

@svituz svituz commented Oct 24, 2023

Negotiator pull request:

Description:

PR that implements attachments for negotiations and refactors posts.
Adds also authorization for attachments and posts

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • [x ] I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (2a00865) 73.80% compared to head (494c32a) 76.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
+ Coverage     73.80%   76.28%   +2.48%     
- Complexity      541      585      +44     
============================================
  Files            83       83              
  Lines          1252     1299      +47     
  Branches         70       78       +8     
============================================
+ Hits            924      991      +67     
+ Misses          267      245      -22     
- Partials         61       63       +2     
Flag Coverage Δ
integration 76.28% <82.58%> (+2.48%) ⬆️
unit 42.64% <64.51%> (+4.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tiator/api/controller/v3/AttachmentController.java 46.15% <100.00%> (ø)
...iator/api/controller/v3/NegotiationController.java 66.66% <100.00%> (ø)
...e/negotiator/api/controller/v3/PostController.java 91.66% <100.00%> (ø)
.../service/negotiator/database/model/Attachment.java 83.33% <100.00%> (+3.33%) ⬆️
...service/negotiator/database/model/AuditEntity.java 87.50% <100.00%> (+1.78%) ⬆️
.../service/negotiator/database/model/DataSource.java 38.77% <100.00%> (ø)
...service/negotiator/database/model/Negotiation.java 82.50% <ø> (-5.00%) ⬇️
...ervice/negotiator/database/model/Organization.java 75.00% <100.00%> (+5.76%) ⬆️
...c/csit/service/negotiator/database/model/Post.java 90.90% <100.00%> (+10.90%) ⬆️
...it/service/negotiator/database/model/PostType.java 100.00% <ø> (ø)
... and 23 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

svituz and others added 7 commits October 24, 2023 17:27
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik linked an issue Oct 27, 2023 that may be closed by this pull request
@svituz svituz merged commit 760198c into master Oct 30, 2023
9 checks passed
@svituz svituz deleted the feat/posts_and_attachments branch October 30, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for attachments.
2 participants