Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QRegister fails to ensure qubit uniqueness #35

Closed
ahelsing opened this issue Jun 13, 2019 · 1 comment
Closed

QRegister fails to ensure qubit uniqueness #35

ahelsing opened this issue Jun 13, 2019 · 1 comment
Assignees
@ahelsing

Comments

@ahelsing
Copy link
Contributor

The QRegister constructor tries to ensure any qubit appears at most once in a given QRegister. This seems to have bugs. Note that a given qubit likely will appear in multiple registers, but should only appear once in a given register.

See related issues #31, #32, #33, #34. (Particularly #32)
@ahelsing ahelsing self-assigned this Jun 24, 2019
ahelsing added a commit that referenced this issue Jun 25, 2019
@ahelsing
- Fix issue #35
322c306 
 - if a single arg and it is int, handle specially
 - else for each Arg, allow it to be a tuple, list, QRegister, String, or a Qubit
  - QRegister: Append all qubits in the arg to the local set of qubits, ignoring any duplicates
  - String: Try parsing as 'q#' and append that to local set if not already present
  - Fix issue #31: Qubit: Try parsing name as 'q#' and append that to local set if not already present
  - Fix Issue #32: list/tuple: Recurse
ahelsing added a commit that referenced this issue Oct 11, 2019
@ahelsing
Merge branch 'fixbasicseq.rb'
923e2a2 
 - Updates to working BasicSequences and notebooks, and up to date documentation
 - Addresses issues #55, #38
 - Also addresses #35, #32, #31
 - Also #26, #25, #21
@ahelsing
Copy link
Contributor Author

Duplicates are now removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahelsing ahelsing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahelsing