Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change QGL imports to reflect refactoring changes (ChannelLibrary) #21

Closed
dellard opened this issue Jan 3, 2018 · 4 comments
Closed

change QGL imports to reflect refactoring changes (ChannelLibrary) #21

dellard opened this issue Jan 3, 2018 · 4 comments
Assignees
@ahelsing

Comments

@dellard
Copy link
Contributor

dellard commented Jan 3, 2018

QGL.ChannelLibrary was renamed to QGL.ChannelLibraries, but pyqgl2 was not updated. This is a small change, but touches many modules.

It's possible that there were other name changes that happened during the same refactoring; if so they will be addressed as well.
@dieris
Copy link
Collaborator

dieris commented Jan 3, 2018

@dellard Please take a look at this branch https://github.com/BBN-Q/pyqgl2/commits/fix/qgl1
It doesn't pass tests, but it includes that and other fixes.

@dellard
Copy link
Contributor Author

dellard commented Jan 4, 2018

There were also some changes to the names of class members.

Diego also pointed out that there is a branch https://github.com/BBN-Q/pyqgl2/commits/fix/qgl1 that addresses some or all of this issue.

@ahelsing ahelsing self-assigned this Jun 13, 2019
@ahelsing
Copy link
Contributor

Working on branch fixbasicseq

@ahelsing ahelsing mentioned this issue Jun 13, 2019
Closed
ahelsing added a commit that referenced this issue Oct 11, 2019
@ahelsing
Merge branch 'fixbasicseq.rb'
923e2a2 
 - Updates to working BasicSequences and notebooks, and up to date documentation
 - Addresses issues #55, #38
 - Also addresses #35, #32, #31
 - Also #26, #25, #21
@ahelsing
Copy link
Contributor

I believe I've caught all the renaming; things all work against current QGL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahelsing ahelsing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dieris @ahelsing @dellard