Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all Jumpgates' ids_info to use extensive infocard #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change all Jumpgates' ids_info to use extensive infocard #236

wants to merge 1 commit into from

Conversation

erikroe
Copy link
Collaborator

@erikroe erikroe commented Jun 14, 2024

Change all Jumpgates' ids_info to use extensive infocard provded by the game already (re-using existing resources.dll infocard used in solararch.ini)

grafik

BC46
BC46 requested changes Jun 18, 2024
View reviewed changes
Copy link
Owner

@BC46 BC46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDS 60246 is a Trade Lane infocard. I think you meant to replace all the entries with IDS 60210.

@BC46
Copy link
Owner

BC46 commented Aug 18, 2024

See #235 (comment).

@BC46 BC46 marked this pull request as draft August 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BC46 BC46 BC46 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikroe @BC46