Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: minor modification to allow in-memory conversion of ADL files #59

Merged
merged 1 commit into from
Apr 13, 2021
Merged

REF: minor modification to allow in-memory conversion of ADL files #59

merged 1 commit into from
Apr 13, 2021

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Apr 12, 2021 •
edited
Loading

This works well in my testing for the initially loaded file.

Some additional work will be needed for:

  • Related displays: there needs to be a configurable flag somewhere as to whether or not to change .adl -> .ui (or leave it alone, as we want for the pydm loader)

@hhslepicka hhslepicka mentioned this pull request Apr 12, 2021
Merged
prjemian
prjemian approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the contribution!

@prjemian prjemian merged commit bb01986 into BCDA-APS:main Apr 13, 2021
@klauer klauer deleted the ref_in_memory branch April 13, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klauer @prjemian