Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept automatic MEDM ADL converter and loader #723

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

klauer
Copy link
Collaborator

@klauer klauer commented Mar 19, 2021

Considered a proof-of-concept because 1 prerequisites are is not yet merged.

Prerequisites

#578 (merged here for convenience, or rather out of necessity for the converter to work)
My branch of adl2pydm https://github.com/klauer/adl2pydm/tree/ref_in_memory (tweak to allow in-memory conversion of ADL screens)

Functionality

Actual functionality only in 2 small commits: bf560cb, 753e8f7

Result

$ pydm ~/Repos/adl2pydm/tests/medm/mca-R7-7-mca.adl
[2021-03-18 17:00:10,549] [ERROR   ] - Loading /Users/klauer/Repos/adl2pydm/tests/medm/mca-R7-7-mca.adl file by way of load_adl_file...
[2021-03-18 17:00:10,607] [INFO    ] - Environment variable PYDM_DISPLAYS_PATH is not defined.
[2021-03-18 17:00:10,607] [INFO    ] - file not found: stylesheet.qss
[2021-03-18 17:00:10,607] [INFO    ] - writing screen file: None

Screenshot

image

Why?

  • We want areaDetector screens and other community-provided ones easily available at some point.
  • areaDetector provides ADL screens in its standard distribution as do many other packages.
  • Ideally, EDL (EDM) loading would be added at some point with a similar hook. This is really what PCDS would like in the end.

pydm/display.py Outdated Show resolved Hide resolved
pydm/display.py Outdated Show resolved Hide resolved
@hhslepicka
Copy link
Contributor

That looks really cool! Thank you for the PR and generalization of the load file... that opens up some nice possibilities.
I will work on getting the PyDM widgets PRs reviewed and merged so we can move this forward.
For now I left 2 small suggestions.

@klauer
Copy link
Collaborator Author

klauer commented Mar 19, 2021

Thanks, @hhslepicka. 👍

(cc @prjemian for input as this is based on his project)

@hhslepicka
Copy link
Contributor

#578 was merged in...
Once BCDA-APS/adl2pydm#59 is in let's rebase and get this change in...

@klauer
Copy link
Collaborator Author

klauer commented Apr 12, 2021

Rebased and tested briefly:
pydm -m P=sim:,M=mtr1 ~/Repos/adl2pydm/tests/medm/motorx_all-R6-10-1.adl

Looking pretty good overall:
image

@klauer klauer marked this pull request as ready for review April 14, 2021 16:48
@hhslepicka hhslepicka merged commit 534f1ad into slaclab:master Apr 14, 2021
@hhslepicka
Copy link
Contributor

Thank you for the great addition @klauer! This will open a very nice path towards more converters...

@klauer klauer deleted the adl_loader branch April 14, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants