Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BEC in lup() and lineup() plans with PySumReg #884

Closed
prjemian opened this issue Nov 14, 2023 · 3 comments · Fixed by #886
Closed

Replace BEC in lup() and lineup() plans with PySumReg #884

prjemian opened this issue Nov 14, 2023 · 3 comments · Fixed by #886
Assignees
@prjemian
Labels
enhancement
Projects
1.6.18 project
Milestone
1.6.18

Comments

@prjemian
Copy link
Contributor

The BEC requires a display for it to display a LivePlot. The config of the LivePlot is used to setup the PeakStats object that returns centroid, width, et al. This is not available when running the Bluesky queueserver. Consequently, the lup() and lineup() plans do not run.

PySumReg can provide peak statistics. Apply it here.
@prjemian prjemian added this to the 1.6.18 milestone Nov 14, 2023
@prjemian prjemian self-assigned this Nov 14, 2023
@prjemian prjemian added this to To do in 1.6.18 project via automation Nov 14, 2023
@prjemian
Copy link
Contributor Author

Also, find a way to write the statistics into a stream of the run.

@prjemian
Copy link
Contributor Author

Could use this in a callback subscribed to the RE or just decorating a lup() or lineup() plan.

@prjemian
Copy link
Contributor Author

Better to decorate the inner plan in lup and lineup with this callback. That controls when it is used.

prjemian added a commit that referenced this issue Nov 16, 2023
@prjemian
ENH #884 lineup2 statistics use PySumReg now
6e4e248
prjemian added a commit that referenced this issue Nov 16, 2023
@prjemian
TST #884
f98fbc0
prjemian added a commit that referenced this issue Nov 16, 2023
@prjemian
DOC #884
d8c2fae
@prjemian prjemian mentioned this issue Nov 16, 2023
Merged
@prjemian prjemian moved this from To do to In progress in 1.6.18 project Nov 16, 2023
prjemian added a commit that referenced this issue Nov 16, 2023
@prjemian
DOC #884
305d939
1.6.18 project automation moved this from In progress to Done Nov 16, 2023
@prjemian prjemian mentioned this issue Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
enhancement
Projects
No open projects
1.6.18 project
  
Done
Milestone
1.6.18
Development

Successfully merging a pull request may close this issue.

new lineup2() plan can be used with queueserver, console, and notebooks BCDA-APS/apstools
1 participant
@prjemian