HHL Slits Added to APS Tools

[MDecarabas]

• close Hoist support for HHL white beam slits from haven #923

[prjemian]

[action-black] Checking python code using the black formatter...
would reformat /github/workspace/apstools/devices/hhl_slits.py

Oh no! 💥 💔 💥
1 file would be reformatted, 159 files would be left unchanged.

[prjemian]

More files need to be updated:

apstools/apstools/devices/__init__.py

Line 66 in 7201a73

from .hhl_slits import HHLSlits

[MDecarabas]

[action-black] Checking python code using the black formatter...
would reformat /github/workspace/apstools/devices/hhl_slits.py
Oh no! 💥 💔 💥
1 file would be reformatted, 159 files would be left unchanged.

No idea why this is happening. Formatted using vscode extension and then separately using the Conda-forge package. No change to the file

[prjemian]

apstools/docs/source/api/_devices.rst

Line 153 in 7201a73

~apstools.devices.xia_slit.XiaSlit2D

    ~apstools.devices.hhl_slits.HHLSlits
    ~apstools.devices.xia_slit.XiaSlit2D

apstools/docs/source/api/_devices.rst

Line 319 in 7201a73

.. automodule:: apstools.devices.hhl_slits
    :members:
    :private-members:
    :show-inheritance:
    :inherited-members:```

[prjemian]

[action-black] Checking python code using the black formatter...
would reformat /github/workspace/apstools/devices/hhl_slits.py
Oh no! 💥 💔 💥
1 file would be reformatted, 159 files would be left unchanged.

No idea why this is happening. Formatted using vscode extension and then separately using the Conda-forge package. No change to the file

I agree. The logs are not informative. I can check out your branch and diagnose locally. Meanwhile, is there a verbosity level we can add to the workflow?

apstools/.github/workflows/code.yml

Lines 39 to 42 in f4d15a9

	- name: Run black
	uses: rickstaa/action-black@v1
	with:
	black_args: ". --check"

Consult the repo for the action.

[canismarko]

Black v24 dropped recently, and picks up stuff that black v23 does not. I had to upgrade my local env to black v24.

[prjemian]

Locally, this is the change:

Blank line 45 removed after method signature.

[prjemian]

@MDecarabas - Did you test this with the actual EPICS controls, with the HHL slits at 25-ID? That's one type of review.

[prjemian]

LGTM!

[prjemian]

Er, one more thing to update is the CHANGES.rst file (the release notes).

[prjemian]

This file: https://github.com/BCDA-APS/apstools/blob/hhl_slits/CHANGES.rst

Add entry for the new support, following previous examples.

[MDecarabas]

@MDecarabas - Did you test this with the actual EPICS controls, with the HHL slits at 25-ID? That's one type of review.

Yes I did

[prjemian]

Change history addition, such as:

apstools/CHANGES.rst

Lines 43 to 47 in 7a5eaca

	New Features
	------------
	* Add (ophyd) device support for:
	* DG-645 digital delay/pulse generator.

(New section under the 1.6.19 release notes.)

[prjemian]

Also note the expected date of Feb 29 has been pushed by a month to Mar 31. Feb 29 was not realistic.

[prjemian]

You can change that text, as well.